Repository navigation
Conversation
Large deep-buffer requests can exceed the range of the HDA gateway minimum-buffer-size register. Cap the preferred allocation at UINT16_MAX rounded down to a whole DMA allocation unit, and reject configurations whose minimum buffer already exceeds that limit. Keep non-HDA DMA allocation unchanged and use the actual allocated size for the existing DMA setup. Signed-off-by: Peter Ujfalusi <[email protected]>
Apply the UAOL input formats and S32 internal formats to both deep-buffer playback pipelines, and advertise the same PCM channel and rate capabilities as normal playback. Calculate the minimum host buffer size from the configured minimum rate rather than a fixed 48 kHz, and update the mixer compatibility description. Signed-off-by: Peter Ujfalusi <[email protected]>
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The supplied review evidence identifies no active issues requiring changes.
No open issues 🎉
What changed in this PR
This PR expands UAOL deep-buffer PCM support to match normal playback and limits HDA DMA buffer sizes to avoid exceeding the 16-bit DGMBS register limit.
Changes:
- Enable the shared UAOL formats, rates, and channel ranges in both deep-buffer pipelines.
- Calculate minimum PCM buffer sizes using the minimum supported rate and channel count.
- Cap HDA DMA buffers at aligned sizes within 65,535 bytes, rejecting configurations whose minimum allocation exceeds that limit.
| File | Description |
|---|---|
| tools/topology/topology2/platform/intel/uaol-generic.conf | Update comments to describe matching playback capabilities and mixer requirements. |
| tools/topology/topology2/platform/intel/uaol-deep-buffer1.conf | Expand the second deep-buffer PCM’s capabilities and adjust minimum buffer sizing. |
| tools/topology/topology2/platform/intel/uaol-deep-buffer.conf | Expand the first deep-buffer PCM’s capabilities and adjust minimum buffer sizing. |
| src/audio/host-zephyr.c | Enforce the HDA DMA buffer limit while preserving allocation alignment. |
Review effort: Balanced
PR 11483: test resultsRun date: 2026-11-18 10:45 UTC Tested commit: 0a2184a2e0ce7218c422baa16a194fd624a5c445 |
lgirdwood
approved these changes
Nov 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow the same range of formats to be supported via the Deep Buffer UAOL PCMs as we support via the normal ones.
This change uncovered an issue that if we have 192KHz or higher sampling rate than the host buffer size will increase beyond 65,535 bytes, which is the limit for the DGMBS HDA register and this has not been checked, resulting mixer underruns when using high sampling rate (or more channels).